container-image: provide a Monocle container based on UBI 8 #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Monocle build is done with ghc 9.4.6 Using 9.6.x was made difficult due to dependencies requierments issues. This patch includes changes: - Remove usage of `isLowerCase` as only available in base >= 4.18 - Add some overrides in cabal-override.project - Cap effectful-core to monocle.cabal to match the version used via Nix. 2.3.0.0 brings functions type changes.
morucci
changed the title
blackheaven
reviewed
Oct 8, 2023
| @@ -502,7 +502,7 @@ mkIndexName name = do | |||
| let check explanation p = if p then Right () else Left explanation | |||
| check "Is empty" $ not $ T.null name | |||
| check "Is longer than 255 bytes" $ BS.length (T.encodeUtf8 name) < 256 | |||
| check "Contains uppercase letter(s)" $ T.all (\x -> not (isLetter x) || isLowerCase x) name | |||
| check "Contains uppercase letter(s)" $ T.all (\x -> not (isLetter x) || isLower x) name | |||
There was a problem hiding this comment.
On that image I use ghc 9.4 and it seems that isLowerCase is only available from base 4.18 1, however base 4.18 is available with ghc 9.6 2.
This PR uses ghc 9.4, however ideally using 9.6 will be better as that's the one we use under nix. Dependencies issues went a bit too far using 9.6 then I stopped and fallback to use 9.4 for now.
There was a problem hiding this comment.
Thanks for the explanation.
TristanCacqueray
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.