crawler - github - index the mergeCommit's sha #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Monocle/Backend/Index.hs
Outdated
| ] | ||
|
|
||
| mergedCommitField :: [Pair] | ||
| mergedCommitField = ["merged_commit_sha" .= NonIndexedMapping] |
There was a problem hiding this comment.
Perhaps this should be indexed, so that later we can do filter based on this field?
@leonid-deriv would that works for your use-case?
There was a problem hiding this comment.
Well, I've updated the PR to use the standard keyword mapping for that field.
There was a problem hiding this comment.
Honestly, I am not sure I fully understand the question. For us, the most important thing is that mergeCommit should be available in the elastic (in Change and ideally in ChangeMergedEvent)
TristanCacqueray
approved these changes
Oct 25, 2023
The previous commit sets the field as non indexed meaning that it was only stored an retreivable but not searchable. This commit changes this field setting as a standard keywork field to make it searcheable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1072