Add author' groups into Monocle Idents #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morucci
force-pushed
the
1084
branch
2 times, most recently
from
e213766 to
f2dcbbd
Compare
morucci
changed the title
src/Monocle/Backend/Test.hs
Outdated
| eve = Author "eve" "e" | ||
| fakeAuthor = Author "John" "John" | ||
| fakeAuthorAlt = Author "John Doe/12" "review.opendev.org/John Doe/12" | ||
| alice = Author "alice" "a" mempty |
There was a problem hiding this comment.
to avoid these changes, we could define a pattern synonym like this:
pattern Author :: Text -> AuthorWithGroup
pattern Author name = AuthorWithGroup name mempty… and then rename the data constructor to AuthorWithGroup
There was a problem hiding this comment.
If you don't mind I prefer the simplest approach via a function called mkAuthorWithNoGroup.
morucci
changed the title
|
The change is ready to land IMO. |
TristanCacqueray
approved these changes
Dec 12, 2023
| @@ -201,6 +204,9 @@ type WorkspaceName = IndexName | |||
|
|
|||
| type WorkspaceStatus = Map WorkspaceName Status | |||
|
|
|||
| -- | IdentInfo is the Monocle UID and the list of Groups | |||
| type IdentUG = (Text, [Text]) | |||
There was a problem hiding this comment.
nit: might be cleaner to use a data record instead of type alias to prevent using the tuple form (like in getIdentByAliasFromIdents below)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.