Catch elasticsearch error within the API #1100
Merged
+181
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TristanCacqueray
force-pushed
the
catch-error
branch
from
ff71f31 to
d61021f
Compare
|
Would be nice to have a test (e.g. inject a change without a target_branch before performing a search). |
This change adds error handling code to catch elastic client exceptions. Though this change keeps the "call error on failure" behavior using the `dieOnEsError` helper.
TristanCacqueray
force-pushed
the
catch-error
branch
from
d61021f to
cc4b911
Compare
morucci
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves error reporting when the elastic client throws errors. The implementation is done in the
Monocle.Effectsmodule.