Skip to content

Commit

Permalink
Add the font-family format supported by Google Web Font (#2209)
Browse files Browse the repository at this point in the history
<!--
  How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [x] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [x] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Summary

<!-- Please brief explanation of the changes made -->

Add the font-family format supported by Google Web Font
(ex. NotoSansKR -> Noto Sans KR)

Considering the existing uses, we only add the contents without
modifying them

<img width="1463" alt="스크린샷 2024-05-09 오후 5 34 50"
src="https://github.com/channel-io/bezier-react/assets/55074799/d558c32f-e654-4939-8565-b723193faf2c">


### Breaking change? (Yes/No)

<!-- If Yes, please describe the impact and migration path for users -->
No

## References

<!-- Please list any other resources or points the reviewer should be
aware of -->
- https://fonts.google.com/selection/embed
  • Loading branch information
leejiwoo2002 authored May 10, 2024
1 parent ffecfdf commit 79072d9
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/eight-birds-care.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@channel.io/bezier-tokens": patch
---

Add the font-family format supported by Google Web Font
4 changes: 4 additions & 0 deletions packages/bezier-tokens/src/global/font.json
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,9 @@
"value": [
"Inter",
"NotoSansKR",
"Noto Sans KR",
"NotoSansJP",
"Noto Sans JP",
"-apple-system",
"BlinkMacSystemFont",
"Helvetica Neue",
Expand All @@ -117,7 +119,9 @@
"value": [
"Inter",
"NotoSansJP",
"Noto Sans JP",
"NotoSansKR",
"Noto Sans KR",
"-apple-system",
"BlinkMacSystemFont",
"Helvetica Neue",
Expand Down

0 comments on commit 79072d9

Please sign in to comment.