Add build job with turbo cache to CI #1615

sungik-choi · 2023-09-11T09:18:06Z

Self Checklist

I wrote a PR title in English and added an appropriate label to the PR.
I wrote the commit message in English and to follow the Conventional Commits specification.
I added the changeset about the changes that needed to be released. (or didn't have to)
I wrote or updated documentation related to the changes. (or didn't have to)
I wrote or updated tests related to the changes. (or didn't have to)
I tested the changes in various browsers. (or didn't have to)
- Windows: Chrome, Edge, (Optional) Firefox
- macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Summary

빌드 잡을 CI에 추가합니다.
빌드 잡에 캐시를 추가합니다.

Details

기존에 --filter=bezier-icons 를 통해 아이콘 패키지만 빌드하던 것에서 필터를 제거하고, 모든 패키지를 빌드하도록 변경합니다. 의존성 업데이트 등 변경이 있었을 경우 라이브러리가 정상적으로 빌드되는 지 검증하기 위해서입니다. #1424 에서 빌드 시간이 많이 단축되었지만, 필터가 제거되었으므로 총 빌드 시간도 유의미하게 증가하게 될 거라 생각했습니다. 이를 방지하고자 빌드 잡에 캐시를 추가했습니다.

빌드 잡에 캐시 추가

기존엔 jest의 캐시가 없었습니다. 캐시 관련 설정을 추가합니다.
- 마이너: 캐시 설정을 추가하며 jest 설정을 레포지토리 전반적으로 통일합니다. jest 관련 패키지를 루트로 옮기고, @swc/jest 를 모든 패키지에 적용하여 테스트 수행시간을 줄이고자 했습니다. 기본값과 동일하거나 불필요한 jest 설정 옵션은 제거했습니다.
test:ci 스크립트를 제거하고 기존 test: jest --onlyChanged 스크립트를 test:ci 와 동일한 스크립트로 변경합니다. 기존에 only changed 플래그가 추가되었던 이유가 pre-commit 훅을 빠르게 수행하기 위해서였는데, pre-commit 훅이 제거되었기때문에 불필요해졌다고 판단했습니다.

Breaking change? (Yes/No)

No

changeset-bot · 2023-09-11T09:18:09Z

⚠️ No Changeset found

Latest commit: 76d7b6d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2023-09-11T09:24:19Z

Chromatic Report

🚀 Congratulations! Your build was successful!

codecov · 2023-09-11T09:24:38Z

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5042b04) 87.18% compared to head (76d7b6d) 87.18%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1615   +/-   ##
=======================================
  Coverage   87.18%   87.18%           
=======================================
  Files         281      281           
  Lines        3903     3903           
  Branches      821      821           
=======================================
  Hits         3403     3403           
  Misses        425      425           
  Partials       75       75

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/chromatic.yml

.github/workflows/ci.yml

.github/workflows/chromatic.yml

add gitignore

…peline

…kage

… in parallel

sungik-choi · 2023-09-21T05:47:57Z

상술한 빌드 잡의 캐시를 워크플로우(CI, Chromatic, Release)간 공유, 전체적인 워크플로우 수행 시간을 단축시키기 위해 CI를 GitHub Actions로 이동했습니다. 같은 캐시 공간을 사용하기 때문에, 캐시 키(sha)만 동일하다면 캐시가 잘 히트될 것이라고 기대하고 있습니다.

-> 액션간 캐싱이 잘 동작하지 않아서, GitHub Actions으로 옮길 당위성이 부족하다고 판단, 고민중입니다. FYI. @yangwooseong

.github/workflows/chromatic.yml

see: https://turbo.build/repo/docs/core-concepts/monorepos/task-dependencies#from-arbitrary-workspaces

see: https://turbo.build/repo/docs/core-concepts/monorepos/running-tasks#turborepo-can-multitask

sungik-choi · 2023-10-10T13:27:55Z

docs: add github actions/cache example to github ci docs vercel/turborepo#2761 의 Approach가 잘 안됨. https://turbo.build/repo/docs/reference/command-line-reference/run#--cache-dir cache-dir 도 설정이 잘 되어있는데...
여전히 GitHub Actions으로 옮기는 게 맞는지 의문.

…erformance time

…attach performance time" This reverts commit 1629c28.

sungik-choi

FYI. @yangwooseong

GitHub Actions로 옮길까 했으나, 저희 DevOps팀이 CircleCI를 사용하고 있으며 + GitHub Actions로 옮겼을 때 워크플로우간의 캐시 공유는 여전히 불가능하므로, 기존과 같이 CircleCI를 사용했습니다. 워크플로우간 & 다른 사람간 캐시 공유를 위해선 리모트 캐싱은 필수불가결한 거 같아요.
CircleCI orb(codecov)를 최신으로 업데이트했습니다.
machine resource를 기존 x-large가 과하다고 생각하여, large로 downgrade 해보려고 했으나 test 단계에서 리소스 문제로 뻗어버리더군요(SIGKILL).. 이 부분은 유지합니다

TODO

빌드 캐시는 잘 동작하는 것을 확인했습니다!
다만 lint, typecheck, test 캐시는 계속 miss하는 것으로 보아 현재 유의미하게 동작하는 거 같지 않아요. 테스트해보고, 불필요하다면 제거해도 괜찮을 거 같습니다.

sungik-choi · 2023-10-17T08:53:31Z

.circleci/config.yml


 workflows:
-  version: 2


sungik-choi · 2023-10-17T08:53:46Z

.circleci/config.yml

-filter_only_tagged: &filter_only_tagged
-  filters:
-    tags:
-      only: /^v.*/
-    branches:
-      ignore: /.*/


leejiwoo2002 · 2023-10-17T12:54:33Z

데스크에서 turbo cache를 붙였다가 뗐었는데 이런 이슈가 있었어요 cc.@Kanary159357

Cache keeps growing indefinitely vercel/turborepo#863

sungik-choi added the chore:system Issue or PR regarding source environment (e.g. lints, tests), not the actual source code label Sep 11, 2023

sungik-choi self-assigned this Sep 11, 2023

sungik-choi requested a review from yangwooseong as a code owner September 11, 2023 09:18

sungik-choi commented Sep 11, 2023

View reviewed changes

.github/workflows/chromatic.yml Show resolved Hide resolved

sungik-choi force-pushed the ci/build branch from 56b4e66 to 93d6912 Compare September 11, 2023 10:11

yangwooseong reviewed Sep 12, 2023

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

.github/workflows/chromatic.yml Outdated Show resolved Hide resolved

sungik-choi requested a review from yangwooseong September 19, 2023 04:59

yangwooseong approved these changes Sep 19, 2023

View reviewed changes

sungik-choi added 12 commits September 19, 2023 19:40

test(jest): config cache directory

ed0969f

add gitignore

ci: move ci workflow fron circle ci to github actions

e256636

ci: apply cache and refine each step

986416d

build: remove test:ci script and add jest cache to outputs of test pi…

ba0572a

…peline

chore(deps): move jest-relate packages from each packages to root pac…

8dab4e6

…kage

chore: remove onlyChanged flag of test script

7a9c9cf

test: unify test setup with SWC and add cache directory

1815991

ci(validate): improved execution of lint, typecheck, and test scripts…

337ea6f

… in parallel

chore: add .jestcache to clean script

481b472

ci: seperate cache key based on workflow

ea59e54

refactor(ci): use default fetch depth option of actions/checkout

5a903e7

refactor(ci): change the hard-coded node version to .nvmrc directory

989a12b

sungik-choi force-pushed the ci/build branch from 3ffeff0 to 989a12b Compare September 19, 2023 10:42

sungik-choi marked this pull request as draft September 21, 2023 05:48

sungik-choi changed the title ~~Add build job with turbo cache to CI and move CI from CircleCI to GitHub Actions~~ [WIP] Add build job with turbo cache to CI and move CI from CircleCI to GitHub Actions Sep 21, 2023

sungik-choi commented Sep 21, 2023

View reviewed changes

.github/workflows/chromatic.yml Outdated Show resolved Hide resolved

sungik-choi added 2 commits October 10, 2023 20:52

Merge branch 'main' into ci/build

11e1dae

chore(deps): clean up dependecies

90f2750

sungik-choi added 3 commits October 10, 2023 21:54

build(turbo): define workspace-tasks

7c36660

see: https://turbo.build/repo/docs/core-concepts/monorepos/task-dependencies#from-arbitrary-workspaces

ci(github): use turbo pipeline instead of custom validate script

542e3bd

see: https://turbo.build/repo/docs/core-concepts/monorepos/running-tasks#turborepo-can-multitask

ci(github): fix chromatic workflow

eb10825

sungik-choi marked this pull request as ready for review October 10, 2023 13:14

sungik-choi added 8 commits October 17, 2023 13:32

Merge branch 'main' into ci/build

e98c23e

ci(circle): revert config.yml

1590bb6

build(packages): unify typecheck script

9b79f79

ci: remove ci github action and revert circle ci config file

e0b140e

ci: add new line

9866576

ci(circle): remove unnecessary token param

392fcc9

ci(circle): remove disallowed key

2b2e9a3

build(turbo): remove unnecessary workflow pipeline

eaecc7f

sungik-choi changed the title ~~[WIP] Add build job with turbo cache to CI and move CI from CircleCI to GitHub Actions~~ Add build job with turbo cache to CI Oct 17, 2023

sungik-choi added 4 commits October 17, 2023 16:34

ci(circle): changed to a single pipeline to reduce workspace attach p…

1629c28

…erformance time

Revert "ci(circle): changed to a single pipeline to reduce workspace …

e9c1a49

…attach performance time" This reverts commit 1629c28.

ci(circle): enhance workspace and cache config

7a786af

ci(circle): fix workspace path

7649906

sungik-choi marked this pull request as draft October 17, 2023 07:58

sungik-choi added 3 commits October 17, 2023 17:19

ci(circle): wip: add concurrency option to prevent SIGKILL

43a6453

ci(circle): change concurrency number from 2 to 1

d5ada1b

ci(circle): use xlarge resource and remove concurrency option

535a26f

sungik-choi commented Oct 17, 2023

View reviewed changes

sungik-choi marked this pull request as ready for review October 17, 2023 08:49

sungik-choi commented Oct 17, 2023

View reviewed changes

.circleci/config.yml

workflows:

version: 2

Copy link

Contributor Author

sungik-choi Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deprecated

sungik-choi commented Oct 17, 2023

View reviewed changes

ci(chromatic): remove unnecessary diffs

76d7b6d

sungik-choi merged commit f3945b9 into channel-io:main Oct 17, 2023
6 checks passed

sungik-choi deleted the ci/build branch October 17, 2023 09:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add build job with turbo cache to CI #1615

Add build job with turbo cache to CI #1615

sungik-choi commented Sep 11, 2023 •

edited

Loading

changeset-bot bot commented Sep 11, 2023 •

edited

Loading

github-actions bot commented Sep 11, 2023 •

edited

Loading

codecov bot commented Sep 11, 2023 •

edited

Loading

sungik-choi commented Sep 21, 2023

sungik-choi commented Oct 10, 2023

sungik-choi left a comment •

edited

Loading

sungik-choi Oct 17, 2023

sungik-choi Oct 17, 2023

leejiwoo2002 commented Oct 17, 2023

Add build job with turbo cache to CI #1615

Add build job with turbo cache to CI #1615

Conversation

sungik-choi commented Sep 11, 2023 • edited Loading

Self Checklist

Related Issue

Summary

Details

빌드 잡에 캐시 추가

Breaking change? (Yes/No)

changeset-bot bot commented Sep 11, 2023 • edited Loading

⚠️ No Changeset found

github-actions bot commented Sep 11, 2023 • edited Loading

Chromatic Report

codecov bot commented Sep 11, 2023 • edited Loading

Codecov Report

sungik-choi commented Sep 21, 2023

sungik-choi commented Oct 10, 2023

sungik-choi left a comment • edited Loading

Choose a reason for hiding this comment

TODO

sungik-choi Oct 17, 2023

Choose a reason for hiding this comment

sungik-choi Oct 17, 2023

Choose a reason for hiding this comment

leejiwoo2002 commented Oct 17, 2023

sungik-choi commented Sep 11, 2023 •

edited

Loading

changeset-bot bot commented Sep 11, 2023 •

edited

Loading

github-actions bot commented Sep 11, 2023 •

edited

Loading

codecov bot commented Sep 11, 2023 •

edited

Loading

sungik-choi left a comment •

edited

Loading