Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback login when there is no icon update with figma plugin #1630

Conversation

yangwooseong
Copy link
Collaborator

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Fixes #1627

Summary

  • 아이콘 업데이트 없이 이전과 동일한 상태로 플러그인을 동작시키면 깃헙 액션이 에러를 뱉는 것을 수정합니다.

Details

Breaking change? (Yes/No)

No

References

@yangwooseong yangwooseong added the bug Issues related to anything that isn't working label Sep 14, 2023
@yangwooseong yangwooseong self-assigned this Sep 14, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2023

⚠️ No Changeset found

Latest commit: 7183218

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@sungik-choi sungik-choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 라벨 bug -> fix로 바꿔주세요!

@yangwooseong yangwooseong added fix PR related to bug fix and removed bug Issues related to anything that isn't working labels Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (dbb115b) 86.96% compared to head (7183218) 86.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1630   +/-   ##
=======================================
  Coverage   86.96%   86.96%           
=======================================
  Files         281      281           
  Lines        3882     3882           
  Branches      820      820           
=======================================
  Hits         3376     3376           
  Misses        432      432           
  Partials       74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yangwooseong yangwooseong force-pushed the fix/add-fallback-when-no-icon-update branch from 16d9530 to 7183218 Compare September 14, 2023 11:03
@yangwooseong yangwooseong merged commit ab3062e into channel-io:main Sep 14, 2023
5 checks passed
@yangwooseong yangwooseong deleted the fix/add-fallback-when-no-icon-update branch September 14, 2023 11:08
@yangwooseong yangwooseong added the bezier-figma-plugin Issue or PR related to bezier-figma-plugin label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bezier-figma-plugin Issue or PR related to bezier-figma-plugin fix PR related to bug fix
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

github action throws error when icon is not updated
2 participants