-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(foundation-styled-component): export styleSheetManager #1645
feat(foundation-styled-component): export styleSheetManager #1645
Conversation
🦋 Changeset detectedLatest commit: 636cdb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Chromatic Report🚀 Congratulations! Your build was successful! |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1645 +/- ##
==========================================
- Coverage 86.96% 86.94% -0.03%
==========================================
Files 281 281
Lines 3882 3883 +1
Branches 820 820
==========================================
Hits 3376 3376
- Misses 432 433 +1
Partials 74 74
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR 타이틀만 바꿔주시면 좋을 거 같습니다! newWindow
보다, 모듈명(foundation-styled-component
)이 들어가는 게 적절할 거 같아요.
@sungik-choi codecov가 테스트 커버리지 재는 도구같은데, 요 PR에서 해줘야 할 게 있나요? |
없습니다~! 테스트 케이스를 추가하기도 애매해서, Approve 완료되면 수동으로 merge할게요 |
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @channel.io/[email protected] ### Minor Changes - Update icons ([#1640](#1640)) by @kimminkyung94 **CHANGE** - PageDownload - PageZip - Page ## @channel.io/[email protected] ### Minor Changes - Added StyleSheetManager to export ([#1645](#1645)) by @leejiwoo2002 ### Patch Changes - Implement the feature to add scripts by injecting a window object into the `activate` function of `SmoothCornersFeatures`, if needed. ([#1642](#1642)) by @sungik-choi ```tsx SmoothCornersFeature.activate(window); ``` ## [email protected] ### Patch Changes - Updated dependencies - @channel.io/[email protected] - @channel.io/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Self Checklist
Related Issue
Summary
Details
Breaking change? (Yes/No)
No
References