Add AlphaAvatarGroup component
#2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add default valut to `max` props - remove unused eventhandler props - remove `ellipsisStyle`, `ellipsisClassName` props
- remove padding right of count text - modify selector for size
- use types from AlphaAvatar - rm AvatarGroupEllipsisType export - add 16 to avatar size
🦋 Changeset detectedLatest commit: 4d2a295 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Chromatic Report🚀 Congratulations! Your build was successful! |
…tar count is less than max
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2177 +/- ##
==========================================
+ Coverage 86.80% 86.83% +0.03%
==========================================
Files 128 130 +2
Lines 2735 2803 +68
Branches 815 828 +13
==========================================
+ Hits 2374 2434 +60
- Misses 332 340 +8
Partials 29 29 ☔ View full report in Codecov by Sentry. |
sungik-choi
approved these changes
Apr 25, 2024
| } | ||
| } | ||
|
|
||
| function getSpreadRadius(size: AvatarSize) { |
There was a problem hiding this comment.
마이너) getShadow 함수 내부로 인라인해도 될 거 같아요.
Comment on lines
+88
to
+89
| const avatarGroupContext = useAvatarGroupContext() | ||
| const size = avatarGroupContext?.size ?? sizeProps |
sungik-choi
pushed a commit
that referenced
this pull request
Apr 26, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @channel.io/[email protected] ### Patch Changes - Implement `AlphaAvatar` component. ([#2162](#2162)) by @yangwooseong - Add `AlphaAvatarGroup` component ([#2177](#2177)) by @yangwooseong - Updated dependencies - @channel.io/[email protected] ## @channel.io/[email protected] ### Patch Changes - Add `opacity-disabled` to alpha token. ([#2162](#2162)) by @yangwooseong - Fix the value of alpha color.cobalt.300 ([#2160](#2160)) by @sungik-choi ## [email protected] ### Patch Changes - Updated dependencies - @channel.io/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yangwooseong
pushed a commit
to yangwooseong/bezier-react
that referenced
this pull request
May 2, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @channel.io/[email protected] ### Patch Changes - Implement `AlphaAvatar` component. ([channel-io#2162](channel-io#2162)) by @yangwooseong - Add `AlphaAvatarGroup` component ([channel-io#2177](channel-io#2177)) by @yangwooseong - Updated dependencies - @channel.io/[email protected] ## @channel.io/[email protected] ### Patch Changes - Add `opacity-disabled` to alpha token. ([channel-io#2162](channel-io#2162)) by @yangwooseong - Fix the value of alpha color.cobalt.300 ([channel-io#2160](channel-io#2160)) by @sungik-choi ## [email protected] ### Patch Changes - Updated dependencies - @channel.io/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self Checklist
Related Issue
Summary
AlphaAvatarGroup컴포넌트를 구현합니다.Details
ellipsisStyle,ellipsisClassName,onMouseEnterEllipsis,onMouseLeaveEllipsis속성이 없어졌습니다.Breaking change? (Yes/No)
References