Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change source props type of Icon component #2344

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

yangwooseong
Copy link
Collaborator

@yangwooseong yangwooseong commented Jul 9, 2024

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Summary

  • bezier-icons 의 type declaration 에서 선언되는 타입을 수정하면서 Icon 컴포넌트가 받는 source 타입을 수정하지 않아 사용처에서 타입 에러가 뜹니다. 베지어에서는 타입 체크가 통과되고 있는 것은 아마 @types/[email protected] 버전에서 breaking change가 생긴 것에 의한 영향인 것 같습니다.

Details

  • Icon 의 인터페이스를 BezierIcon 을 바라보도록 수정합니다. Button types 의 LeftContent에서도 BezierIcon 을 직접 바라보고 있어서 일관성 측면에서도 이렇게 하는 게 나아보입니다.

Breaking change? (Yes/No)

  • No

References

@yangwooseong yangwooseong added the fix PR related to bug fix label Jul 9, 2024
@yangwooseong yangwooseong self-assigned this Jul 9, 2024
@yangwooseong yangwooseong requested a review from sungik-choi as a code owner July 9, 2024 07:25
Copy link

changeset-bot bot commented Jul 9, 2024

🦋 Changeset detected

Latest commit: 455128b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

channeltalk bot commented Jul 9, 2024

Copy link
Contributor

github-actions bot commented Jul 9, 2024

Chromatic Report

🚀 Congratulations! Your build was successful!

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.86%. Comparing base (c3bf62a) to head (455128b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2344   +/-   ##
=======================================
  Coverage   83.86%   83.86%           
=======================================
  Files         140      140           
  Lines        2919     2919           
  Branches      879      892   +13     
=======================================
  Hits         2448     2448           
+ Misses        466      441   -25     
- Partials        5       30   +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yangwooseong yangwooseong merged commit 441690f into channel-io:main Jul 10, 2024
9 checks passed
@yangwooseong yangwooseong deleted the WEB-2674/icon-interfac-fix branch July 10, 2024 04:21
yangwooseong pushed a commit that referenced this pull request Jul 10, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @channel.io/[email protected]

### Patch Changes

- Change `source` type of IconProps to `BezierIcon`
([#2344](#2344)) by
@yangwooseong

## [email protected]

### Patch Changes

-   Updated dependencies
    -   @channel.io/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix PR related to bug fix
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants