Fix runtime error in isBezierIcon function
#2348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ddcdeb9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2348 +/- ##
=======================================
Coverage 83.86% 83.86%
=======================================
Files 140 140
Lines 2919 2919
Branches 892 892
=======================================
Hits 2448 2448
Misses 441 441
Partials 30 30 ☔ View full report in Codecov by Sentry. |
sungik-choi
approved these changes
Jul 12, 2024
| @@ -6,7 +6,7 @@ | |||
| const BEZIER_ICON_ID = '__bezier__icon' | |||
|
|
|||
| export function isBezierIcon(arg: any) { | |||
| return typeof arg === 'object' && arg[BEZIER_ICON_ID] === true | |||
| return !!arg && typeof arg === 'object' && arg[BEZIER_ICON_ID] === true | |||
yangwooseong
force-pushed
the
fix/is-bezier-icon-bug
branch
from
0464e1d to
ddcdeb9
Compare
yangwooseong
pushed a commit
that referenced
this pull request
Jul 12, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @channel.io/[email protected] ### Patch Changes - Check if value is nullish in `isBezierIcon` function to block runtime error. ([#2348](#2348)) by @yangwooseong ## [email protected] ### Patch Changes - Updated dependencies - @channel.io/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self Checklist
Related Issue
Summary
아래 함수에서 생길 수 있는 버그를 수정합니다. arg가 null 일 때 typeof arg === 'object' 이기 때문에 런타임 에러가 납니다.
Details
Breaking change? (Yes/No)
References