Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove icons.json related step in github action #2358

Conversation

yangwooseong
Copy link
Collaborator

@yangwooseong yangwooseong commented Jul 16, 2024

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Summary

  • 피그마 플러그인에 의해 만들어진 icons.json에 따라 아이콘 svg파일을 만드는 스텝을 액션에서 제거합니다.

Details

Breaking change? (Yes/No)

  • No

References

@yangwooseong yangwooseong added the bezier-icons Issue or PR related to bezier-icons label Jul 16, 2024
@yangwooseong yangwooseong self-assigned this Jul 16, 2024
Copy link

changeset-bot bot commented Jul 16, 2024

⚠️ No Changeset found

Latest commit: 1f320a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

channeltalk bot commented Jul 16, 2024

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.86%. Comparing base (59ca436) to head (1f320a0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2358   +/-   ##
=======================================
  Coverage   83.86%   83.86%           
=======================================
  Files         140      140           
  Lines        2919     2919           
  Branches      879      892   +13     
=======================================
  Hits         2448     2448           
+ Misses        466      441   -25     
- Partials        5       30   +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yangwooseong yangwooseong force-pushed the WEB-2858/change-pr-description-action branch from 1eedb70 to 1f320a0 Compare July 17, 2024 05:31
@yangwooseong yangwooseong merged commit fb80498 into channel-io:main Jul 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bezier-icons Issue or PR related to bezier-icons
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants