Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong pr description in icon update PR #2379

Merged

Conversation

yangwooseong
Copy link
Collaborator

@yangwooseong yangwooseong commented Jul 23, 2024

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

  • None

Summary

Details

  • PR본문을 추가하는 워크플로우에서 checkout 액션의 fetch-depth가 default(=1) 이라서 파일이 변경된 것으로 인식하지 않고 추가된것으로 인식해서 모두 Add로 나왔습니다. 0으로 바꿔서 모든 커밋 히스토리를 가져오도록 수정했습니다.
  • 누락된 changeset commit push 를 추가합니다.

Breaking change? (Yes/No)

  • No

References

@yangwooseong yangwooseong added the fix PR related to bug fix label Jul 23, 2024
@yangwooseong yangwooseong self-assigned this Jul 23, 2024
Copy link

channeltalk bot commented Jul 23, 2024

Copy link

changeset-bot bot commented Jul 23, 2024

⚠️ No Changeset found

Latest commit: 7336494

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.86%. Comparing base (fa5ea81) to head (7336494).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2379   +/-   ##
=======================================
  Coverage   83.86%   83.86%           
=======================================
  Files         140      140           
  Lines        2919     2919           
  Branches      879      879           
=======================================
  Hits         2448     2448           
  Misses        466      466           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yangwooseong yangwooseong merged commit ea19873 into channel-io:main Jul 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix PR related to bug fix
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants