Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon update PR made by bezier-asset main #2380

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Conversation

ch-builder
Copy link
Contributor

@ch-builder ch-builder commented Jul 23, 2024

Icon update is ready to be merged! 🎉

  • All icons modified with svgo optimizing

Copy link

changeset-bot bot commented Jul 23, 2024

🦋 Changeset detected

Latest commit: 76d6d16

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-icons Minor
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

channeltalk bot commented Jul 23, 2024

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.86%. Comparing base (ea19873) to head (937289d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2380   +/-   ##
=======================================
  Coverage   83.86%   83.86%           
=======================================
  Files         140      140           
  Lines        2919     2919           
  Branches      892      892           
=======================================
  Hits         2448     2448           
+ Misses        466      441   -25     
- Partials        5       30   +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@yangwooseong yangwooseong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bezier-asset에서 svgo로 최적화를 거친 에셋들이 업데이트되서 모든 아이콘이 변경되었습니다. 굳이 모든 아이콘을 나열할 필요는 없을 것 같아서 changeset과 PR description 을 수정했습니다.

변경 전 후에 빌드 결과물이 동일한 것을 확인했습니다.

@yangwooseong yangwooseong force-pushed the icon-update-main branch 2 times, most recently from c29489f to 76d6d16 Compare July 25, 2024 05:16
@yangwooseong yangwooseong merged commit 61cd3d3 into main Jul 25, 2024
8 checks passed
@yangwooseong yangwooseong deleted the icon-update-main branch July 25, 2024 05:25
yangwooseong pushed a commit that referenced this pull request Jul 25, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @channel.io/[email protected]

### Minor Changes

- Optimize all icon assets with svgo.
([#2380](#2380)) by
@ch-builder

- Update icons
([#2384](#2384)) by
@ch-builder

    Modified

    -   apps-add.svg
    -   exclusive.svg

    Added

    -   widget.svg

## [email protected]

### Patch Changes

-   Updated dependencies
    -   @channel.io/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants