Fix bezier-vscode extension bug #2507
Conversation
yangwooseong
added
fix
🦋 Changeset detectedLatest commit: 9d9c1a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2507 +/- ##
=======================================
Coverage 81.88% 81.88%
=======================================
Files 145 145
Lines 2887 2887
Branches 918 918
=======================================
Hits 2364 2364
Misses 493 493
Partials 30 30 ☔ View full report in Codecov by Sentry. |
yangwooseong
force-pushed
the
WEB-5626/bezier-vscode
branch
2 times, most recently
from
6cfb1cb to
e468d98
Compare
There was a problem hiding this comment.
bezier-vscode, client, server의 yarn.lock 파일은 버전관리하지 않아도 될 거 같아요
There was a problem hiding this comment.
버전관리 하지 않는 다는 의미를 이해못했습니다..!
There was a problem hiding this comment.
git에 포함할 필요가 없을 거 같다는 뜻이었어요
There was a problem hiding this comment.
"workspaces": [
"client",
"server"
],
"installConfig": {
"hoistingLimits": "dependencies"
},테스트하다 발견한건데, workspace와 installConfig.hoistingLimits를 혼합해서 사용하면 cd - install 없이 루트에서 node_modules 생성 위치를 제어할 수 있네요. 이 방법으로 테스트해봐주실 수 있나요?
이 방식을 적용하면 root workspace에 추가한 "packages/bezier-vscode/*" path도 제거할 수 있을 거 같아요
yarn install 결과
There was a problem hiding this comment.
이 방식을 적용하면 root workspace에 추가한 "packages/bezier-vscode/*" path도 제거할 수 있을 거 같아요
제거할경우 터보레포의 태스크 의존성 관리가 안되어서, 아래 태스크를 추가해야하네요
"bezier-vscode#build": {
"outputs": ["dist/**"], // client, server도 추가?
"dependsOn": ["@channel.io/bezier-tokens#build"]
},There was a problem hiding this comment.
이거 이렇게 하고 패키징 해보니까 language server client connection 이 안된다는 에러가 뜨네요 😢
There was a problem hiding this comment.
설치되는 의존성은 동일할 거 같은데...
There was a problem hiding this comment.
이전에는 client/node_modules 밑에 client 가 필요한 의존성을 다 들고 있었는데, 지금은 소수만(vscode-languageclient)들고 있고 대부분은 호이스팅되서 bezier-vscode/node_moduls로 빠지네요. 아예 다 호이스팅해버리거나 안하거나 하면 괜찮아질 것 같아서 그 방법을 찾아봐야 할 것 같습니다. -> client, server 각각의 package.json 에서 hoistingLimits 를 설정하니 되는것 같네요. 이걸로 다시 해볼게요
packages/bezier-vscode/package.json
Outdated
| @@ -60,16 +60,8 @@ | |||
| "typecheck": "tsc --noEmit", | |||
| "clean": "rm -rf dist", | |||
There was a problem hiding this comment.
client, server의 dist와 node_modules 등도 지웠으면 좋겠습니다
turbo.json
Outdated
| "bezier-vscode#build": { | ||
| "outputs": ["client/dist/**", "server/dist/**"], | ||
| "dependsOn": ["@channel.io/bezier-tokens#build"] | ||
| }, |
yangwooseong
force-pushed
the
WEB-5626/bezier-vscode
branch
from
7431421 to
da22761
Compare
|
- When packaging, it was impossible to reference dependencies in the parent directory
- modify resolve path in client.ts which caused runtime error after packaging - add .yarn to .vscodeignore to reduce package size
…skip-duplicate" of publish
…ver file as well - not necessary to include node_modules because dependencies are included in bundle
yangwooseong
force-pushed
the
WEB-5626/bezier-vscode
branch
from
8c2d76c to
9d9c1a9
Compare
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @channel.io/[email protected] ### Minor Changes - Add SCSS support to access design tokens directly through SCSS variables. ([#2568](#2568)) by @sungik-choi ## @channel.io/[email protected] ### Patch Changes - Export the `alphaTokens`, `AlphaTokens`, and `useAlphaTokens` modules. ([#2564](#2564)) by @sungik-choi - Updated dependencies - @channel.io/[email protected] ## @channel.io/[email protected] ### Patch Changes - Updated dependencies - @channel.io/[email protected] ## [email protected] ### Minor Changes - Fixed bug where autocomplete did not work. ([#2507](#2507)) by @yangwooseong ### Patch Changes - Updated dependencies - @channel.io/[email protected] ## [email protected] ### Patch Changes - Updated dependencies - @channel.io/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Self Checklist
Related Issue
Summary
Details
vsce package --no-yarn-> npm 으로 패키지를 시도하면invalid relative path: extension/../../vscode-languageclient/node에러가 뜹니다. 상대경로를 제대로 resolve 하지 못하는 것 같습니다.vsce package-> yarn 으로 패키지를 시도하면 vsce 내에서yarn list --no-prod --no-json명령어를 수행하는데, 이 명령어는 yarn v1 에서만 있는 명령어라 현재 베지어 레포의 yarn 버전과 맞지 않아서 명령어를 실행할 수 없다는 에러가 뜹니다.yarn list --no-prod --no-json를 yarn 플러그인으로 대체하는 옵션까지 했지만vsce ls결과물에 의존성이 포함되지 않았습니다.정리
vsce package/publish 에서 상위 디렉토리에 있는 의존성을 가져올 수 없는 문제때문에 server, client 패키지를 beizer-vscode 패키지 안에 만들고, package/publish 단계에서 server,client 패키지안에 의존성을 설치
Breaking change? (Yes/No)
References