Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alpha design token types #2564

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Conversation

sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Dec 13, 2024

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Summary

  • 알파 버전의 디자인 토큰 타입을 추가합니다
  • 알파 버전의 디자인 토큰 프로바이더와 관련 훅, 토큰 객체를 export 합니다.

Details

  • alphaTokens 로 토큰 객체에, AlphaTokens 네임스페이스로 토큰 타입에 접근할 수 있도록 합니다.
  • useAlphaTokens 훅으로 자바스크립트에서 현재 테마명에 맞는 알파 버전 디자인 토큰에 접근할 수 있습니다.
  • ThemeProviderAlphaThemeProvider 를 별도로 두어야하나 고민했지만, 이미 알파 디자인 토큰이 스타일 시트에 말려들어가있어서 ThemeProvider 하나만(= AppProvider 하나만) 사용하더라도 useAlphaTokens 훅을 사용할 수 있도록 해도 괜찮겠다고 생각했습니다.
  • 현재 토큰 객체 구조상, 타이핑할 때 Functional Semantic 토큰을 묶어서 지칭할 수 있는 용어가 필요한데 현재 디자인 시스템에는 따로 정의가 없습니다. 임시로 학습 비용이 최대한 적은 방향으로, 기존과 동일하게 SemanticToken 이라고 칭했습니다.

Breaking change? (Yes/No)

No

References

없음

@sungik-choi sungik-choi added the feat Issue or PR related to a new feature label Dec 13, 2024
@sungik-choi sungik-choi self-assigned this Dec 13, 2024
Copy link

changeset-bot bot commented Dec 13, 2024

🦋 Changeset detected

Latest commit: ae9ed4f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

channeltalk bot commented Dec 13, 2024

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Chromatic Report

🚀 Congratulations! Your build was successful!

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.88%. Comparing base (7908274) to head (ae9ed4f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...act/src/components/ThemeProvider/ThemeProvider.tsx 33.33% 2 Missing ⚠️
...rc/components/AlphaTokenProvider/TokenProvider.tsx 87.50% 1 Missing ⚠️
...r-react/src/components/AlphaTokenProvider/index.ts 66.66% 1 Missing ⚠️
...bezier-react/src/components/ThemeProvider/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2564      +/-   ##
==========================================
- Coverage   81.95%   81.88%   -0.08%     
==========================================
  Files         143      145       +2     
  Lines        2871     2887      +16     
  Branches      918      918              
==========================================
+ Hits         2353     2364      +11     
+ Misses        514      493      -21     
- Partials        4       30      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sungik-choi sungik-choi marked this pull request as ready for review December 16, 2024 10:37
@sungik-choi sungik-choi merged commit bc4319e into channel-io:main Dec 17, 2024
7 of 9 checks passed
@sungik-choi sungik-choi deleted the web-4647 branch December 17, 2024 04:53
sungik-choi pushed a commit that referenced this pull request Dec 19, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @channel.io/[email protected]

### Minor Changes

- Add SCSS support to access design tokens directly through SCSS
variables.
([#2568](#2568)) by
@sungik-choi

## @channel.io/[email protected]

### Patch Changes

- Export the `alphaTokens`, `AlphaTokens`, and `useAlphaTokens` modules.
([#2564](#2564)) by
@sungik-choi

-   Updated dependencies
    -   @channel.io/[email protected]

## @channel.io/[email protected]

### Patch Changes

-   Updated dependencies
    -   @channel.io/[email protected]

## [email protected]

### Minor Changes

- Fixed bug where autocomplete did not work.
([#2507](#2507)) by
@yangwooseong

### Patch Changes

-   Updated dependencies
    -   @channel.io/[email protected]

## [email protected]

### Patch Changes

-   Updated dependencies
    -   @channel.io/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue or PR related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants