fix(release): test github release

chanzuckerberg · Sep 5, 2023 · 5d5c588 · 5d5c588
1 parent 7664df0
commit 5d5c588
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -58,7 +58,7 @@ jobs:
       # Step 8: Lerna Version
       - name: Lerna Version
         env:
-          ssh-key: "${{ secrets.COMMIT_KEY }}"
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
         run: yarn version:ci
 
@@ -81,6 +81,7 @@ jobs:
       - name: Checkout main
         uses: actions/checkout@v3
         with:
+          ssh-key: "${{ secrets.COMMIT_KEY }}"
           ref: main
 
       # Step 12: Reset promotion branch

diff --git a/package.json b/package.json
@@ -118,7 +118,7 @@
     "lint": "lerna run lint",
     "build": "lerna run build",
     "ci": "yarn install --immutable",
-    "version:ci":"HUSKY=0 lerna version --yes --no-changelog --conventional-commits",
+    "version:ci":"HUSKY=0 lerna version --yes --conventional-commits --create-release github",
     "publish:ci": "HUSKY=0 lerna publish from-package --yes"
   },
   "lint-staged": {

diff --git a/packages/components/src/core/DropdownMenu/index.stories.tsx b/packages/components/src/core/DropdownMenu/index.stories.tsx
@@ -50,7 +50,7 @@ const DropdownMenu = <Multiple extends boolean | undefined = false>(
     if (isControlled) {
       setValue(propValue);
     }
-  }, [propValue]);
+  }, [propValue, isControlled]);
 
   return (
     <div style={{ margin: "16px 0 0 24px" }} ref={anchorRef}>
@@ -704,7 +704,7 @@ const TestDemo = (props: Args): JSX.Element => {
 
   useEffect(() => {
     setAnchorEl(anchorRef.current);
-  }, [anchorRef.current]);
+  }, []);
 
   return (
     <div style={{ margin: "16px 0 0 24px" }} ref={anchorRef}>