fix(dropdown): fix dropdown useEffect dependencies

chanzuckerberg · Sep 21, 2023 · 9618c42 · 9618c42
1 parent 3959a9f
commit 9618c42
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/components/src/core/Dropdown/index.tsx b/packages/components/src/core/Dropdown/index.tsx
@@ -111,13 +111,13 @@ const Dropdown = <Multiple extends boolean | undefined = false>({
 
   useEffect(() => {
     onChange(value);
-  }, [value]);
+  }, [onChange, value]);
 
   useEffect(() => {
     if (isControlled) {
       setValue(propValue);
     }
-  }, [propValue]);
+  }, [isControlled, propValue]);
 
   const [open, setOpen] = useState(false);