Merge branch 'prod' of https://github.com/chanzuckerberg/sci-components…

… into test-gh-workflows
chanzuckerberg · Sep 6, 2023 · b673e80 · b673e80
2 parents 413e04f + 189da9c
commit b673e80
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 10 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -58,7 +58,7 @@ jobs:
       # Step 8: Lerna Version
       - name: Lerna Version
         env:
-          ssh-key: "${{ secrets.COMMIT_KEY }}"
+          GITHUB_TOKEN: ${{ secrets.SDS_LERNA_VERSION_PAT }}
           NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
         run: yarn version:ci
 
@@ -81,6 +81,7 @@ jobs:
       - name: Checkout main
         uses: actions/checkout@v3
         with:
+          ssh-key: "${{ secrets.COMMIT_KEY }}"
           ref: main
 
       # Step 12: Reset promotion branch

diff --git a/package.json b/package.json
@@ -118,7 +118,7 @@
     "lint": "lerna run lint",
     "build": "lerna run build",
     "ci": "yarn install --immutable",
-    "version:ci":"HUSKY=0 lerna version --yes --no-changelog --conventional-commits",
+    "version:ci":"HUSKY=0 lerna version --yes --conventional-commits",
     "publish:ci": "HUSKY=0 lerna publish from-package --yes"
   },
   "lint-staged": {

diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md
@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [17.0.2](https://github.com/chanzuckerberg/sci-components/compare/@czi-sds/[email protected]...@czi-sds/[email protected]) (2023-09-05)
+
+### Bug Fixes
+
+- **release:** fix lerna version access token ([c6e2eb1](https://github.com/chanzuckerberg/sci-components/commit/c6e2eb1436d4b96f1c625b6c6b9e2d198f8ef7e4))
+- **release:** remove --create-release from lerna version ([f1dd1cf](https://github.com/chanzuckerberg/sci-components/commit/f1dd1cf514f8182ca4bca71c82f7701deec301e5))
+- **release:** test github release ([5d5c588](https://github.com/chanzuckerberg/sci-components/commit/5d5c5880efc07c74175c118e23014a6ee8e959bc))
+
 ## [14.6.2](https://github.com/chanzuckerberg/sci-components/compare/@czi-sds/[email protected]...@czi-sds/[email protected]) (2023-04-26)
 
 **Note:** Version bump only for package @czi-sds/components
diff --git a/packages/components/package.json b/packages/components/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@czi-sds/components",
-  "version": "17.0.1",
+  "version": "17.0.2",
   "main": "dist/index.cjs.js",
   "module": "dist/index.esm.js",
   "repository": {

diff --git a/packages/components/src/core/DropdownMenu/index.stories.tsx b/packages/components/src/core/DropdownMenu/index.stories.tsx
@@ -44,13 +44,13 @@ const DropdownMenu = <Multiple extends boolean | undefined = false>(
 
   useEffect(() => {
     setAnchorEl(anchorRef.current);
-  }, [anchorRef.current]);
+  }, []);
 
   useEffect(() => {
     if (isControlled) {
       setValue(propValue);
     }
-  }, [propValue]);
+  }, [propValue, isControlled]);
 
   return (
     <div style={{ margin: "16px 0 0 24px" }} ref={anchorRef}>
@@ -72,10 +72,7 @@ const DropdownMenu = <Multiple extends boolean | undefined = false>(
           title={title}
           value={multiple ? pendingValue : value}
           getOptionDisabled={(option: DefaultDropdownMenuOption) => {
-            return (
-              option.name === "Type: feature request" ||
-              option.name === "Type: documentation"
-            );
+            return option.name === "Type: feature request";
           }}
           {...props}
         />
@@ -704,7 +701,7 @@ const TestDemo = (props: Args): JSX.Element => {
 
   useEffect(() => {
     setAnchorEl(anchorRef.current);
-  }, [anchorRef.current]);
+  }, []);
 
   return (
     <div style={{ margin: "16px 0 0 24px" }} ref={anchorRef}>