Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(all): refactor components and colors based on latest figma changes #902

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

refactor(all): refactor components and colors based on latest figma changes #902

wants to merge 6 commits into from

Conversation

masoudmanson
Copy link
Contributor

@masoudmanson masoudmanson commented Nov 22, 2024 •
edited
Loading

Summary

Everything
Github issue: #901

Checklist

  • Default Story in Storybook
  • LivePreview Story in Storybook
  • Test Story in Storybook
  • Tests written
  • Variables from defaultTheme.ts used wherever possible
  • If updating an existing component, depreciate flag has been used where necessary
  • Chromatic build verified by @chanzuckerberg/sds-design

@masoudmanson masoudmanson linked an issue Nov 22, 2024 that may be closed by this pull request
Refactor Theme and Variables based on Updated Color Design in Figma #901
Open
@masoudmanson masoudmanson self-assigned this Nov 22, 2024
@masoudmanson masoudmanson added Work in Progress This PR is a work in progress P0 Eng labels Nov 22, 2024
tihuan
tihuan approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great overhaul and detailed updates 🙏 Thanks so much!

@masoudmanson masoudmanson added Ready for review This PR is ready for review and removed Work in Progress This PR is a work in progress labels Nov 23, 2024
@masoudmanson
Copy link
Contributor Author

Great overhaul and detailed updates 🙏 Thanks so much!

Wow, that was such a quick review 😯 thank you so much, @tihuan! 🥳🎉😍✨

@masoudmanson masoudmanson mentioned this pull request Nov 23, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tihuan tihuan tihuan approved these changes

@clarsen-czi clarsen-czi Awaiting requested review from clarsen-czi

Assignees

@masoudmanson masoudmanson

Labels
Eng P0 Ready for review This PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Theme and Variables based on Updated Color Design in Figma
2 participants
@masoudmanson @tihuan