feat(icons): adds hub icons #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codemonkey800 from the screenshots it looks like some of the negative space on the icons is being filled in (Rocket, Read, gridThreeDots) - LMK if you need any fixes to the exported SVGs! |
Closed
|
Small versions have been removed, and negative spaces on the large icons have been fixed. |
masoudmanson
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Thanks, @codemonkey800, for adding the new icons! They look great to me. 😍
masoudmanson
added
Ready for release
tihuan
approved these changes
Feb 2, 2024
|
LGTM too! Thanks for adding these, @codemonkey800 🙏 🚀 !! |
masoudmanson
added
Released
and removed
Ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #458
Summary
Structural Element (Base)
Github issue: #458
Component Requirements: napari hub created 5 new icons for use on our new homepage (currently underdevelopment). All Icons are size L/XL
Demos
Rocket
Read
Widget
Grid with three dots
Updated
Checklist
defaultTheme.tsused wherever possible