Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputsearch): fix intent and useInput styles #618

Merged
merged 2 commits into from
Oct 3, 2023
Merged

fix(inputsearch): fix intent and useInput styles #618

merged 2 commits into from
Oct 3, 2023

Conversation

masoudmanson
Copy link
Contributor

@masoudmanson masoudmanson commented Oct 3, 2023 •
edited
Loading

Summary

InputSearch, InputText

Github issue: #617

This fixes the intent and userInput style bugs in the InputSearch and InputText components.

ZeroHeight Issue: https://czi.zeroheight.com/styleguide/s/66099/p/1596f8/c/107465

Checklist

  • Default Story in Storybook
  • LivePreview Story in Storybook
  • Test Story in Storybook
  • Tests written
  • Variables from defaultTheme.ts used wherever possible
  • If updating an existing component, depreciate flag has been used where necessary
  • Chromatic build verified by @chanzuckerberg/sds-design

@masoudmanson masoudmanson linked an issue Oct 3, 2023 that may be closed by this pull request
Refactor InputSearch, InputText and fix styles #617
Closed
@masoudmanson masoudmanson self-assigned this Oct 3, 2023
@masoudmanson masoudmanson added the Ready for review This PR is ready for review label Oct 3, 2023
tihuan
tihuan approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 🎉 👍 Thanks so much, Masoud 🕺 ! !

clarsen-czi
clarsen-czi requested changes Oct 3, 2023
View reviewed changes
Copy link

@clarsen-czi clarsen-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, @masoudmanson ! Only one change needed on the textArea variant—add a handle to allow for manual resizing.

clarsen-czi
clarsen-czi approved these changes Oct 3, 2023
View reviewed changes
Copy link

@clarsen-czi clarsen-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, @masoudmanson ! LGTM!

@masoudmanson masoudmanson merged commit 11430c1 into main Oct 3, 2023
7 checks passed
@masoudmanson masoudmanson deleted the 617-refactor-inputsearch-inputtext-and-fix-styles branch October 3, 2023 21:08
@masoudmanson masoudmanson added Released and removed Ready for review This PR is ready for review labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarsen-czi clarsen-czi clarsen-czi approved these changes

@tihuan tihuan tihuan approved these changes

Assignees

@masoudmanson masoudmanson

Labels
Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor InputSearch, InputText and fix styles
3 participants
@masoudmanson @tihuan @clarsen-czi