feat(designtokens): add narrow fonts to design tokens #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tihuan
reviewed
Nov 7, 2024
packages/components/src/common/styles-dictionary/scss/_variables.scss
Outdated
Show resolved
Hide resolved
… into 842-implement-narrow-screen-font-design-tokens
masoudmanson
deleted the
842-implement-narrow-screen-font-design-tokens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important Note
This should only be merged after PR #884
Summary
Design Tokens
Github issue: #842
We need to include the new narrow font styles in the design tokens to export them as CSS, SCSS, and Tailwind variables. I’ve created a new PR to add these variables on top of Jeremy’s PR (#884).
Checklist
defaultTheme.tsused wherever possible