support binary operation between two sparse matrix #82
+73
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
brainunit/sparsemodule, primarily focusing on enhancing binary operations and improving test cases for sparse matrix formats. The most important changes include adding support for binary operations between sparse matrices of the same format and updating test cases to include gradient-based updates.Enhancements to binary operations:
brainunit/sparse/_coo.py: Added support for binary operations betweenCOOmatrices with the same row and column indices. Updated error messages for unsupported operations to include the operation name.brainunit/sparse/_csr.py: Added support for binary operations betweenCSRmatrices with the same indices and indptr. Updated error messages for unsupported operations to include the operation name. [1] [2]brainunit/sparse/_csr.py: Added support for binary operations betweenCSCmatrices with the same indices and indptr. Updated error messages for unsupported operations to include the operation name. [1] [2]Improvements to test cases:
brainunit/sparse/_coo_test.py: Updated test cases to include gradient-based updates forCOOmatrices.brainunit/sparse/_csr_test.py: Updated test cases to include gradient-based updates forCSRandCSCmatrices. [1] [2]