fix incorrect fsid in 9P2000.L statfs response #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garlick
changed the title
Problem: the description of Rstatfs suggests that an implementation should call statfs(2), but it can now be satisfied with statvfs(3) in a more portable manner. Just refer to statvfs(3). Don't quote structs as that's available elsewhere.
Problem: the remote fsid returned by Tstatfs is incorrect. I botched the construction of fsid from fsid_t (an array of two variable size integers) when building the response to Tstatfs. Just use statvfs(3) instead, which returns the fsid as a single number. It's more portable than statfs(2) so some ifdefs that cover BSD/linux differences can go away. Note that statfs(2) still has to be called to get the file system type if the "statfs-passthrough" option is configured, but f_type seems to be portable across platforms. Fixes chaos#32 Fixes chaos#115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: the remote
fsidreturned inRstatfsis incorrect.I botched the construction of
fsidfromfsid_t f_fsid(an array of two integers whose size can vary across platforms) when buildingRstatfs.Just use
statvfs(3)instead, which returnsf_fsidas a single integer. It's more portable thanstatfs(2)so some ifdefs that cover BSD/linux differences can go away.Note that
statfs(2)still has to be called to get the file system type if thestatfs-passthroughoption is configured, butf_typeseems to be portable across platforms.