diod: keep --foreground option for compatibility #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 3dc9363 ("diod: always run in the foreground") did what it says on the tin and removed the functionality to daemonize. The old --foreground option that disabled daemonization was also removed. The breaks existing setups that were using foreground execution all along via passing --foreground: The option no longer exists and instead the full usage text is printed. As not to break existing setups, let's keep the --foreground option around for now and just turn it a no-op, given that it became the default behavior.
a3f
force-pushed
the
reinstate-foreground-option
branch
from
fb71d52 to
539827e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 3dc9363 ("diod: always run in the foreground") did what it says on the tin and removed the functionality to daemonize. The old --foreground option that disabled daemonization was also removed.
The breaks existing setups that were using foreground execution all along via passing --foreground: The option no longer exists and instead the full usage test is printed.
As not to break existing setups, let's keep the --foreground option around for now and just make it a no-op, given that it became the default behavior.