-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update graal.py to make it compatible with non-public repos #1114
Update graal.py to make it compatible with non-public repos #1114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thanks for the patch. I added some minor comments you need to address before we merge the PR.
For the comment of the commit, I would replace it by:
[graal] Anonymize repository urls
Anonymize raw origin and tag url to make it more universal for
cocom\colic, etc. metrics and to make it compatible with non-public
repos.
Signed-off-by: GrayStranger <[email protected]>
We also require to sign off the commit but the bot is failing for some reason. Maybe the format?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. Apparently now there are some format errors:
Run poetry run flake8
./grimoire_elk/raw/graal.py:20:2: W291 trailing whitespace
./grimoire_elk/raw/graal.py:27:1: E302 expected 2 blank lines, found 1
./grimoire_elk/raw/graal.py:70:1: W293 blank line contains whitespace
Error: Process completed with exit code 1.
fixed sorry, i have no a lot of experience with GitHub contributing :). Hope now it should works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me. Before we merge it, would you mind to squash all commits into one? If you can't do it, I can do it myself.
Btw, test are failing because the last version of poetry doesn't support Python 3.7. We're fixing it.
633a671
to
5a0e38d
Compare
done |
7e1c9be
to
4cbfb99
Compare
fixed signature in commit after sqashing |
@sduenas I think now its all good to let it in, right? :) sorry for ping. |
4cbfb99
to
a9266ec
Compare
There's still some style errors: ./grimoire_elk/raw/graal.py:72:1: W293 blank line contains whitespace |
a9266ec
to
a2edffc
Compare
whitespaces removed |
could you please advice me - how can I perform such checks by myself? |
If you do an online editing of the file I don't really know, but you can always download the file and run the python tool "flake8". The tests use this tool to see if it complies with the PEP8 specification (it's a guide of style for Python). |
a2edffc
to
3ff2366
Compare
Pull Request Test Coverage Report for Build 6468834462
💛 - Coveralls |
@sduenas just friendly reminder to merge it for the next release :) |
Anonymize raw origin and tag url to make it more universal for cocom\colic, etc. metrics and to make it compatible with non-public repos. Signed-off-by: GrayStranger <[email protected]>
3ff2366
to
7693537
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@GrayStranger merged. I updated your branch to include a changelog file that we use for automating realeases and for rebasing to the latest commit. I hope you don't mind. Thanks for your contribution. |
Anonymize raw origin and tag url to make it more universal for cocom\colic etc. backends and to make it compatible with non-public repos.