Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[git] Improve branches study for consistency #1166

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

jjmerchante
Copy link
Contributor

Previously, while the branches study was running, the branches field remained empty or partially filled until the study was completed, leading to incorrect data being displayed on the dashboard.
With this change, the study is first created in an auxiliary field branches_aux, and once complete, the results are moved to the branches field.

Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please fix the issue with flake8.

Previously, while the branches study was running,
the `branches` field remained empty or partially filled
until the study completed, leading to incorrect data
being displayed on the dashboard.
With this change, the study is first created in an
auxiliary field `branches_aux`, and once complete,
the results are moved to the `branches` field.
This approach ensures consistent and accurate data
is displayed.

Signed-off-by: Jose Javier Merchante <[email protected]>
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sduenas sduenas merged commit f76834e into chaoss:master Aug 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants