Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enriched/githubql] Fix enrich_reference_analysis study #1173

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

zhquan
Copy link
Member

@zhquan zhquan commented Oct 10, 2024

This code fixes the enrich_reference_analysis study that only processed the first 10 references instead of all of them. By default, the ElasticSearch/OpenSearch aggregations query only returns the first 10 documents. Using composite aggregations we can paginate the result to get all the references.

Fixes #1172

Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please, check my suggestions.

This code fixes the `enrich_reference_analysis` study that only
processed the first 10 references instead of all of them. By default,
the ElasticSearch/OpenSearch `aggregations` query only returns the
first 10 documents. Using `composite aggregations` we can paginate
the result to get all the references.

Signed-off-by: Quan Zhou <[email protected]>
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sduenas sduenas merged commit e43429e into chaoss:master Oct 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[githubql] The "enrich_reference_analysis" study only fetch 10 references
2 participants