-
Notifications
You must be signed in to change notification settings - Fork 424
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Change naming linting for extern symbols (#26598)
Fixes how we lint extern symbols in chplcheck for name violations. Extern symbols should not be linted for name violations, because they typically come from another language that has different naming conventions. Furthermore, the user may have no control over the type name (i.e. using a third-party library). `chplcheck` already handled this correctly for functions and variables/types, but not for records. This PR rectifies that. This PR also adds an opt-out, if the user has renamed their symbol, then they do have full control of the name and this PR turns on linting in that case. In the following program, we should lint the name `chapelFunc`, because that's a name picked by the user and not relevant to the external name. ```chapel proc "extern_c_func" proc chapelFunc() { } ``` - [x] `start_test test/chplcheck` [Reviewed by @brandon-neth]
- Loading branch information
Showing
3 changed files
with
22 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters