Improve comments, adjust return type to something more appropriate

Signed-off-by: Ben Harshbarger <[email protected]>
chapel-lang · Jan 31, 2025 · fcfa248 · fcfa248
1 parent b5030fd
commit fcfa248
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/frontend/lib/resolution/resolution-queries.cpp b/frontend/lib/resolution/resolution-queries.cpp
@@ -4033,7 +4033,8 @@ static bool resolveFnCallSpecial(Context* context,
       exprTypeOut = QualifiedType::makeParamString(context, oss.str());
       return true;
     } else if (srcTy->isClassType() && dstTy->isClassType()) {
-      // cast (borrowed class) : unmanaged
+      // cast (borrowed class) : unmanaged,
+      // and (unmanaged class) : borrowed
       auto srcClass = srcTy->toClassType();
       auto dstClass = dstTy->toClassType();
       bool isValidDst = dstClass->manageableType()->isAnyClassType() &&

diff --git a/frontend/lib/resolution/return-type-inference.cpp b/frontend/lib/resolution/return-type-inference.cpp
@@ -1304,7 +1304,10 @@ static bool helpComputeReturnType(ResolutionContext* rc,
         result = QualifiedType(QualifiedType::CONST_VAR, VoidType::get(context));
         return true;
       } else {
-        result = QualifiedType(QualifiedType::CONST_VAR, ErroneousType::get(context));
+        // TODO: This is a workaround for a bug where the return type was
+        // not found for some reason. By returning a type we prevent an attempt
+        // to resolve the non-existent function body.
+        result = QualifiedType(QualifiedType::CONST_VAR, UnknownType::get(context));
         return true;
       }
     } else if (fnAstReturnsNonVoid(context, ast->id()) == false) {