Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve associative domain type expr module code in Dyno #26077

Merged
merged 21 commits into from
Jan 16, 2025

Conversation

riftEmber
Copy link
Member

@riftEmber riftEmber commented Oct 11, 2024

Get associative domain type expressions resolving using their module code in Dyno, and re-enable testing for them.

This PR itself contains little work and mostly just drove Dyno work needed to support the module code.

Contributes to https://github.com/Cray/chapel-private/issues/6729.

Also includes:

  • adding a dyno test for rectangular domain literals
  • allowing helpResolveFunction to run on generic type constructors, per bug fix suggestion from Ben
  • adjusting the handling of param == ? comparisons which was introduced in Dyno: Improve initialization of fields from non-matching types #26219, so that it gets specially handled rather than trying to resolve a defined == operator
  • skipping recursing into TupleDecls in VarScopeVisitor to delay implementing call-init-deinit support for them for now
  • an out-of-scope fix in CallInitDeinit::handleDeclarations where we clearly meant to reference type expr, but used init expr
  • moving makeParam[Int,String,Bool] helpers in prims.cpp onto QualifiedType and use everywhere

Future work:

[reviewer info placeholder]

Testing:

  • dyno tests
  • paratest

@riftEmber riftEmber marked this pull request as draft October 11, 2024 20:32
@riftEmber riftEmber force-pushed the dyno-associative-domains branch 2 times, most recently from a365a3f to 8070e30 Compare October 14, 2024 15:37
@riftEmber riftEmber force-pushed the dyno-associative-domains branch 7 times, most recently from cadb922 to 87170da Compare October 31, 2024 19:56
@riftEmber riftEmber force-pushed the dyno-associative-domains branch 12 times, most recently from 62eab18 to 262abef Compare November 22, 2024 19:53
@riftEmber riftEmber changed the title Resolve basic associative domains with module code in Dyno Test basic associative domains with module code in Dyno Nov 22, 2024
@riftEmber riftEmber changed the title Test basic associative domains with module code in Dyno Resolve basic associative domains with module code in Dyno Nov 22, 2024
@riftEmber riftEmber force-pushed the dyno-associative-domains branch 2 times, most recently from 9b06d78 to 10b93b0 Compare November 26, 2024 19:57
@riftEmber riftEmber force-pushed the dyno-associative-domains branch 2 times, most recently from 1a03aef to 9d69475 Compare December 2, 2024 19:17
@riftEmber riftEmber force-pushed the dyno-associative-domains branch 2 times, most recently from 822d66a to ed1773b Compare December 20, 2024 19:26
@riftEmber riftEmber force-pushed the dyno-associative-domains branch from 33c18df to f14929b Compare January 15, 2025 19:18
frontend/include/chpl/types/DomainType.h Outdated Show resolved Hide resolved
frontend/lib/resolution/InitResolver.cpp Show resolved Hide resolved
frontend/lib/resolution/call-init-deinit.cpp Show resolved Hide resolved
frontend/lib/resolution/resolution-queries.cpp Outdated Show resolved Hide resolved
frontend/test/resolution/testDomains.cpp Show resolved Hide resolved
frontend/test/resolution/testDomains.cpp Outdated Show resolved Hide resolved
@riftEmber riftEmber force-pushed the dyno-associative-domains branch from 25769e4 to 7c0c24b Compare January 16, 2025 20:06
@riftEmber riftEmber requested a review from DanilaFe January 16, 2025 20:10
Signed-off-by: Anna Rift <[email protected]>
- Return true from resolveFnCallSpecial if handled
- Invert result for !=

Signed-off-by: Anna Rift <[email protected]>
This was part of the stub implementation of domains for testing, and is
no longer needed.

Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
@riftEmber riftEmber force-pushed the dyno-associative-domains branch from 64ed2d0 to 4cb1dcb Compare January 16, 2025 20:46
@riftEmber riftEmber merged commit e6a8b27 into chapel-lang:main Jan 16, 2025
8 checks passed
@riftEmber riftEmber deleted the dyno-associative-domains branch January 16, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants