-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve associative domain type expr module code in Dyno #26077
Merged
riftEmber
merged 21 commits into
chapel-lang:main
from
riftEmber:dyno-associative-domains
Jan 16, 2025
Merged
Resolve associative domain type expr module code in Dyno #26077
riftEmber
merged 21 commits into
chapel-lang:main
from
riftEmber:dyno-associative-domains
Jan 16, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a365a3f
to
8070e30
Compare
cadb922
to
87170da
Compare
62eab18
to
262abef
Compare
9b06d78
to
10b93b0
Compare
1a03aef
to
9d69475
Compare
822d66a
to
ed1773b
Compare
33c18df
to
f14929b
Compare
2 tasks
DanilaFe
approved these changes
Jan 15, 2025
25769e4
to
7c0c24b
Compare
DanilaFe
approved these changes
Jan 16, 2025
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
- Return true from resolveFnCallSpecial if handled - Invert result for != Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
This was part of the stub implementation of domains for testing, and is no longer needed. Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
64ed2d0
to
4cb1dcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get associative domain type expressions resolving using their module code in Dyno, and re-enable testing for them.
This PR itself contains little work and mostly just drove Dyno work needed to support the module code.
Contributes to https://github.com/Cray/chapel-private/issues/6729.
Also includes:
helpResolveFunction
to run on generic type constructors, per bug fix suggestion from Benparam == ?
comparisons which was introduced in Dyno: Improve initialization of fields from non-matching types #26219, so that it gets specially handled rather than trying to resolve a defined==
operatorTupleDecl
s inVarScopeVisitor
to delay implementing call-init-deinit support for them for nowCallInitDeinit::handleDeclarations
where we clearly meant to reference type expr, but used init exprmakeParam[Int,String,Bool]
helpers inprims.cpp
ontoQualifiedType
and use everywhereFuture work:
[reviewer info placeholder]
Testing: