Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the name location reporting for "if var" and catch statements #26541

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

jabraham17
Copy link
Member

@jabraham17 jabraham17 commented Jan 14, 2025

Fixes the name location reporting for "if var" and catch statements. This fixes issues with the language server, where more than the symbol name would be highlighted.

Cases fixed

if const x = 10 { ... }

try { ... }
catch err: Error {  }

Testing

  • paratest with/without gasnet
  • make test-cls

[Reviewed by @DanilaFe]

Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17 jabraham17 requested a review from DanilaFe January 15, 2025 00:20
@jabraham17 jabraham17 merged commit 1066453 into chapel-lang:main Jan 15, 2025
9 checks passed
@jabraham17 jabraham17 deleted the fix-more-ident-locations branch January 15, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants