c_string removal fixes
#26568
Merged
c_string removal fixes
#26568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danila Fedorin <[email protected]>
C string literals have been removed from Dyno. Signed-off-by: Danila Fedorin <[email protected]>
jabraham17
approved these changes
Jan 18, 2025
| @@ -4,3 +4,4 @@ CHPL_COMM != none | |||
| COMPOPTS <= --no-local | |||
| CHPL_LOCALE_MODEL != flat | |||
| EXECOPTS <= memLeaks | |||
| CHPL_LLVM == none | |||
There was a problem hiding this comment.
If we document --minimal-modules anywhere, I think you should note this limitation there. If we don't, then no need and ignore this comment
There was a problem hiding this comment.
I am not aware of such docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have been causing nightly failures in some corner cases. I had to use
externblocks to use strings with minimal modules (which requires LLVM), and I neglectedCStringLiteralin CLS because it didn't show up as a (C++) use of the now-removed AST node.Reviewed by @jabraham17 -- thanks!
Testing
make test-cls