Add a future to lock in the behavior when an iterator is unstable #26591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I intend to exercise more aspects of it, but this one is sufficient to demonstrate the problem, imo I might change the test based on how running it on another system goes. I suspect that the number of follower calls is variable, but it was good verification that the iterator overload I thought should be called was actually being called ---- Signed-off-by: Lydia Duncan <[email protected]>
Uses an atomic bool to track if we've messaged about the follower already for this set of calls. Clears it in between the first and the second zippered calls ---- Signed-off-by: Lydia Duncan <[email protected]>
---- Signed-off-by: Lydia Duncan <[email protected]>
benharsh
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #26590 . Basically, marking any iterator as unstable will cause the unstable warning to fire, even if that particular iterator is not used. This test demonstrates the issue for serial iterators, but standalone, leader, and follower iterators were also exhibiting the same behavior (and I suspect will be solved by the same solution).