Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop testing ROCm 5.4 in nightly tests #26643

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Stop testing ROCm 5.4 in nightly tests #26643

merged 3 commits into from
Feb 4, 2025
+11 −54

Conversation

jabraham17
Copy link
Member

@jabraham17 jabraham17 commented Feb 3, 2025 •
edited
Loading

This PR removes our nightly ROCm 5.4 testing and updates our docs accordingly

Changes

  • remove ROCm 5.4 correctness testing
  • changed ROCm perf testing to use the default ROCm module (which on our nightly test system is 6)
    • annotated the performance change
  • documented that we no longer test ROCm 5.4

[Reviewed by @e-kayrakli]

@jabraham17
remove testing for rocm 5.4
069fcd5 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
update docs
4084796 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
add annotation
f1bde07 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17 jabraham17 changed the title Stop testing rocm 54 in nightly tests Stop testing ROCm 5.4 in nightly tests Feb 4, 2025
@jabraham17 jabraham17 merged commit 93b034c into chapel-lang:main Feb 4, 2025
8 checks passed
@jabraham17 jabraham17 deleted the stop-testing-rocm54 branch February 4, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-kayrakli e-kayrakli e-kayrakli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jabraham17 @e-kayrakli