fix(image): Fix Imagemagick resize effect

Only apply `^` operator (minimum values of size) if both width and height are supplied, otherwise the image will be cropped to a square.
charcoalphp · Mar 5, 2024 · afbbff5 · afbbff5
1 parent 116a9ce
commit afbbff5
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/packages/image/src/Charcoal/Image/Imagemagick/Effect/ImagemagickResizeEffect.php b/packages/image/src/Charcoal/Image/Imagemagick/Effect/ImagemagickResizeEffect.php
@@ -49,7 +49,14 @@ protected function doResize($width, $height, $bestFit = false)
 
             $size = $width . 'x' . $height;
             if ($bestFit) {
-                $params[] = $option . ' "' . $size . '^"';
+                if ($width && $height) {
+                    // Minimum values of width and height given, aspect ratio preserved.
+                    $operator = '^';
+                } else {
+                    $operator = '';
+                }
+
+                $params[] = $option . ' "' . $size . $operator . '"';
                 $params[] = '-extent ' . $size;
             } else {
                 $params[] = $option . ' ' . $size;