-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing rest-client as a dependency & using native NET:HTTP #85
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still need to remove the line 26, right?
s.add_dependency('rest-client', '>=1.8', '<=2.0.2')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @formigarafa, thanks for the initial review! I’ve implemented the changes you suggested. Could you please re-review? Also, if possible, could you try running this in your test/sandbox environment to verify everything works as expected? Let us know if you encounter any issues.
All good and green ✅ on around here. Thanks. 👍 |
Quality Gate passedIssues Measures |
This branch works on our end for the handful of Chargebee API calls we leverage. |
Hi @jamescook , thank you for your efforts on this! We're planning to roll this out soon and are reviewing your PRs. Please bear with us as we take some time to look into them. |
Replace Deprecated rest-client Dependency with Native Net::HTTP in ChargeBee Ruby SDK
Description:
This PR refactors the ChargeBee Ruby SDK to use Ruby's native
Net::HTTP
library, replacing the deprecatedrest-client
dependency. The rest-client gem, which ChargeBee Ruby previously relied on, has been deprecated and is no longer actively maintained. By switching toNet::HTTP
, this update:Net::HTTP
for HTTP requests, providing a more modern and lightweight solution aligned with Ruby's core library.Changes:
rest-client
have been replaced withNet::HTTP
for making HTTP requests.rest-client
.Net::HTTP
.Testing and Validation: