fix: move @types/q to dependencies.
#39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 28, 2023 17:46
when `@types/q` is lited in `devDependencies` then it is not installed when `chargebee-typescript` is installed. Projects that use `chargebee-typescript` can have problems with the typescript compilation without this package and it can be very frustrating to debug.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Looks like this has been added to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
@types/qis listed indevDependenciesthen it is not installed whenchargebee-typescriptis installed. Projects that usechargebee-typescriptcan have problems with the typescript compilation without this package and it can be very frustrating to debug.The
RequestWrappercomponents.request()method returns aPromisethat is imported from theqpackage. Sincechargebee-tyepscriptis exporting this interface/type from the@types/qpackage it should be listed as a dependency, not a devDependency.