-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuring multiple instances with the client #56
base: master
Are you sure you want to change the base?
Allow configuring multiple instances with the client #56
Conversation
Hello @fsoleraracil, did you intend to create this PR with all these changes? 😅 Also, it's interesting to see the title |
|
Hello @cb-sriramthiagarajan! Now that I have more time I'd like to explain a bit more. At first, we assumed that using the clauses:
Would lead us to have two clients, each configured for their own sites. However, this wasn't the case. The information provided to the Aside of being a bit misleading, it won't allow anyone to have connections to different Chargebee instances in the same application, which is quite inconvenient. Thus, in order to allow this I removed the static code that made the configuration for the site shared across instances.
With this change I kept the compatibility with the current client API while allowing to connect to other instances if necessary. I’ll be glad to help and polish the PR as much as needed to be included in the official client since we are going to use this for a long time and it’s quite a stopper for us. Please reach out to me if you need more information. I’m also available for a call. Thanks for your time |
Hi @fsoleraracil, my apologies for the delay in responding. We have released a new beta version that supports creating You can install this using Edit: We have a Migration guide for v3. README in the |
No description provided.