centralize all the byte_vec type definitions (#37)

charlesnicholson · Aug 31, 2021 · fedca50 · fedca50
1 parent 27ee4d6
commit fedca50
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 20 deletions.
diff --git a/tests/byte_vec.h b/tests/byte_vec.h
@@ -0,0 +1,7 @@
+#pragma once
+
+#include <vector>
+
+using byte_t = unsigned char;
+using byte_vec_t = std::vector<byte_t>;
+
diff --git a/tests/test_cobs_decode_inplace.cc b/tests/test_cobs_decode_inplace.cc
@@ -1,14 +1,11 @@
 #include "../cobs.h"
+#include "byte_vec.h"
 #include "doctest.h"
 
 #include <algorithm>
 #include <cstring>
 #include <numeric>
-#include <vector>
 
-
-using byte_t = unsigned char;
-using byte_vec_t = std::vector< byte_t >;
 static constexpr byte_t CSV = COBS_INPLACE_SENTINEL_VALUE;
 
 namespace {

diff --git a/tests/test_cobs_encode.cc b/tests/test_cobs_encode.cc
@@ -1,11 +1,9 @@
 #include "../cobs.h"
+#include "byte_vec.h"
 #include "doctest.h"
 
-#include <vector>
 #include <cstring>
 
-using byte_vec_t = std::vector< unsigned char >;
-
 TEST_CASE("Encoding validation") {
   unsigned char enc[32], dec[32];
   unsigned const enc_n = sizeof(enc);

diff --git a/tests/test_cobs_encode_inc.cc b/tests/test_cobs_encode_inc.cc
@@ -1,16 +1,13 @@
 #include "../cobs.h"
+#include "byte_vec.h"
 #include "doctest.h"
 
 #include <algorithm>
 #include <iomanip>
 #include <numeric>
 #include <sstream>
-#include <vector>
 
 
-using byte_t = unsigned char;
-using byte_vec_t = std::vector<byte_t>;
-
 TEST_CASE("cobs_encode_inc_begin") {
   cobs_enc_ctx_t ctx;
   std::vector<unsigned char> buf(1024);

diff --git a/tests/test_cobs_encode_inplace.cc b/tests/test_cobs_encode_inplace.cc
@@ -1,12 +1,10 @@
 #include "../cobs.h"
+#include "byte_vec.h"
 #include "doctest.h"
 
 #include <cstring>
 #include <numeric>
-#include <vector>
 
-using byte_t = unsigned char;
-using byte_vec_t = std::vector< byte_t >;
 static constexpr byte_t CSV = COBS_INPLACE_SENTINEL_VALUE;
 
 namespace {

diff --git a/tests/test_paper_figures.cc b/tests/test_paper_figures.cc
@@ -1,9 +1,7 @@
 #include "../cobs.h"
+#include "byte_vec.h"
 #include "doctest.h"
 
-#include <vector>
-
-using byte_vec_t = std::vector< unsigned char >;
 
 // http://www.stuartcheshire.org/papers/COBSforToN.pdf
 TEST_CASE("COBS paper examples") {

diff --git a/tests/test_wikipedia.cc b/tests/test_wikipedia.cc
@@ -1,11 +1,9 @@
 #include "../cobs.h"
+#include "byte_vec.h"
 #include "doctest.h"
 
 #include <numeric>
-#include <vector>
 
-using byte_t = unsigned char;
-using byte_vec_t = std::vector< byte_t >;
 static constexpr byte_t CSV = COBS_INPLACE_SENTINEL_VALUE;
 
 namespace {