Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(v2) tidiness and consistency changes #646

Closed
wants to merge 28 commits into from
Closed

(v2) tidiness and consistency changes #646

wants to merge 28 commits into from

Conversation

meowgorithm
Copy link
Member

@meowgorithm meowgorithm commented Oct 23, 2024 •
edited
Loading

This brings some general consistency to Bubbles as well as general updates to make it work with Lip Gloss v2. A few things happening so far:

  • Things like DefaultStyles and DefaultKeymap are becoming functions, not globals
  • When applicable, focused and blurred styles are children of a larger style struct
  • Sizing (widths, heights) are being standardized on via getters and setters
  • Utility packages not intended for public consumption are being moved to /internal

dependabot bot and others added 28 commits October 23, 2024 17:28
@dependabot
feat(deps): bump github.com/charmbracelet/lipgloss from 0.13.0 to 0.13.1
a9b780a 
Bumps [github.com/charmbracelet/lipgloss](https://github.com/charmbracelet/lipgloss) from 0.13.0 to 0.13.1.
- [Release notes](https://github.com/charmbracelet/lipgloss/releases)
- [Changelog](https://github.com/charmbracelet/lipgloss/blob/master/.goreleaser.yml)
- [Commits](charmbracelet/lipgloss@v0.13.0...v0.13.1)

---
updated-dependencies:
- dependency-name: github.com/charmbracelet/lipgloss
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@meowgorithm
chore(filepicker): use Lip Gloss v2
0892f86
@meowgorithm
feat(filepicker): make symlink symbol customizable
3fc226c
@meowgorithm
chore(help): update for Lip Gloss v2
7d60fd1
@meowgorithm
docs(cursor): fix typo in comment
95e716e
@meowgorithm
chore(list): update for Lip Gloss v2
49c9aca
@meowgorithm
chore(textinput): DefaultKeyMap is now a func that returns a KeyMap
aa1fe05
@meowgorithm
chore(textinput): use getter and setter for width
17533b1
@meowgorithm
chore(textinput): use a getter and setter for width
30d7e7b
@meowgorithm
feat(textinput): add styles for focused and blurred states
432972a
@aymanbagabas
fix(textinput): return a pointer to StyleState
1b34148
@meowgorithm
chore(textarea): update for Lip Gloss v2
a7b0c79
@meowgorithm
chore(textarea): focused/blurred styles now belong to one style struct
f6eb948
@meowgorithm
chore(textarea): remove keymap global in favor of a function
c4f0400
@meowgorithm
chore(runeutil): make package internal
d487f78
@meowgorithm
chore(runeutil): improve package description
d514f3d
@meowgorithm
chore(progress): use getters/setters for width
39fb58b
@meowgorithm
chore(deps): use current v2-exp Bubble Tea
e1d891b
@meowgorithm
docs(textarea): add simple GoDoc for memo package
d05ec83
@meowgorithm
chore(help): fix help test errors
4b2f72b
@meowgorithm
fix(help): fix test by downsampling color to NoTTY
89f2eef
@meowgorithm
chore(list): fix v2 errors
c0611f6
@meowgorithm
chore(textarea): make memoizer internal
812b71c
@meowgorithm
chore(help): simplify ansi stripping in test
5d1f237
@meowgorithm
fix(textarea): fix tests
0e006c7
@dependabot
Merge pull request #645 from charmbracelet/dependabot/go_modules/gith…
7525b8c 
…ub.com/charmbracelet/lipgloss-0.13.1
@meowgorithm
chore(lint): fix and suppress all soft lint issues; update directives
358a6c5
@meowgorithm
chore(merge): branch 'master' into v2-tidy
8827e48
@meowgorithm
Copy link
Member Author

Closing this to tackle things in smaller chunks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymanbagabas aymanbagabas Awaiting requested review from aymanbagabas aymanbagabas will be requested when the pull request is marked ready for review aymanbagabas is a code owner

@bashbunni bashbunni Awaiting requested review from bashbunni bashbunni will be requested when the pull request is marked ready for review bashbunni is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meowgorithm @aymanbagabas