Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
So I added a few features to the migration within charm so that I could feel safe using and merging code while also adding my own migrations. I've attempted to make a 'clean' pr that you could potentially use. I've confirmed this 'builds' and I confirmed my fork works ok, but I didn't 'battle-test' this exact branch. One specific thing I didn't test, I tried to revert my changes to allow libsql driver #250, I didn't test this. if you merge #250 or this pr, the other may need updates. Additionally, I assume you have an existing charm database, you may want to make a patch to add the version table and existing migrations already, although all the current migrations seem to be very safe, (if not exists type of things).
I know this may not be exactly the direction you want to take your tool, so please do close this or suggest any changes you would like. In my other projects I'm using goose, but you had rolled your own so I added to the existing structure. I believe this wouldn't be needed with minimal changes or only changes that are additions/mostly complementary. This is a start towards some safeguards I've become used to from using dedicated tools for these type of things.
is there a way to enable debug mode within charm serve? charm_debug or charm_serve_debug or something? or charm(_serve)(_log)_level?