Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tokyo night #320

Merged
merged 10 commits into from
Aug 5, 2024
Merged

fix: tokyo night #320

merged 10 commits into from
Aug 5, 2024

Conversation

caarlos0
Copy link
Member

refs #318
refs #229

it actually needs to be in Go code. JSON is generated from Go, not sure why.

@caarlos0 caarlos0 added the bug Something isn't working label Jul 30, 2024
@caarlos0 caarlos0 self-assigned this Jul 30, 2024
@caarlos0 caarlos0 requested a review from aymanbagabas as a code owner July 30, 2024 18:20
@caarlos0 caarlos0 mentioned this pull request Jul 30, 2024
Closed
@aymanbagabas
Copy link
Member

@caarlos0 did you mean to base this on another branch?

@bashbunni
Copy link
Member

Sorry for the confusion! This should now be in the right state

aymanbagabas
aymanbagabas approved these changes Jul 31, 2024
View reviewed changes
styles.go Outdated Show resolved Hide resolved
@bashbunni
Copy link
Member

Moved to the styles package, they all still work as expected. Added another example that reads the environment for easier testing of custom styles. It's under stdin-stdout-custom-styles :)

Dracula theme:
image

Tokyo Night:
image

Default:
image

aymanbagabas
aymanbagabas reviewed Jul 31, 2024
View reviewed changes
styles/styles.go Outdated Show resolved Hide resolved
@bashbunni
Copy link
Member

fwiw style test is failing due to the name being case sensitive
image

@bashbunni bashbunni added this to the v0.8.0 milestone Aug 2, 2024
@bashbunni bashbunni linked an issue Aug 2, 2024 that may be closed by this pull request
tokyo_night style does not load #318
Closed
@bashbunni bashbunni merged commit 29b800e into master Aug 5, 2024
16 checks passed
@bashbunni bashbunni deleted the tokyo branch August 5, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashbunni bashbunni bashbunni left review comments

@aymanbagabas aymanbagabas aymanbagabas approved these changes

Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.

tokyo_night style does not load
3 participants
@caarlos0 @aymanbagabas @bashbunni