feat: style ranges #458
Merged
feat: style ranges #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted from charmbracelet/gum#789 , this allows to style ranges of a given string without breaking its current styles. The resulting ansi sequences aren't that beautiful (as there might be many styles+reset with nothing in them), but it works. We can optimize this later I think.
aymanbagabas
reviewed
Jan 7, 2025
meowgorithm
reviewed
Jan 8, 2025
bashbunni
approved these changes
Jan 8, 2025
aymanbagabas
reviewed
Jan 8, 2025
ranges.go
Outdated
| // StyleRanges allows to, given a string, style a range of it differently. | ||
| // The function will take into account existing styles. | ||
| // See [StyleRanges] to style multipe ranges in the same string. | ||
| func StyleRange(s string, start, end int, style Style) string { |
There was a problem hiding this comment.
Instead, maybe we could do StyleRanges(s, NewRange(start, end, style)) where func StyleRanges(s string, ranges ...Range) string 🤔
There was a problem hiding this comment.
yeah sounds good to me as well :)
There was a problem hiding this comment.
Yeah, great call @aymanbagabas. Part of me thinks it should be singular, though, just so users don't think it must take multiple values 🤔. But maybe I'm overthinking it.
There was a problem hiding this comment.
fwiw I'm more inclined into using plural, as it indicates one or more, whereas singular indicates only one...
aymanbagabas
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from charmbracelet/gum#789 , this allows to style ranges of a given string without breaking its current styles.
The resulting ansi sequences aren't that beautiful (as there might be many styles+reset with nothing in them), but it works. We can optimize this later I think.
Also: maybe better waiting for lipgloss v2 and do it there instead. This does not handle renderers for example.