Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: Column wrapping #466

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

wip: Column wrapping #466

wants to merge 8 commits into from

Conversation

bashbunni
Copy link
Member

This PR fixes improper content truncation in lipgloss table. See charmbracelet/glamour#344

You can run go test -run TestContentWrapping -v to see the current output

before:
image

current:
image

TODO:

  • wrap headers if they're long?
  • wrap content if no height is set?
  • more tests for edge cases (wip)

@bashbunni bashbunni added the bug Something isn't working label Jan 24, 2025
@bashbunni
Copy link
Member Author

Still need to iron out some details with the team first, but added some tests that show behaviour we want to modify. They're not failing, just logging outputs because I don't know what the desired output is yet for those cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant