Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(input): un-expose Key.BaseRune + Key GoDocs #83

Merged
merged 4 commits into from
May 17, 2024
Merged

Conversation

meowgorithm
Copy link
Member

No description provided.

@meowgorithm meowgorithm requested a review from aymanbagabas May 17, 2024 15:40
@meowgorithm meowgorithm changed the title docd docs May 17, 2024
@meowgorithm meowgorithm changed the title docs docs(input): GoDocs improvements for Key May 17, 2024
@meowgorithm meowgorithm changed the title docs(input): GoDocs improvements for Key chore(input): un-expose Key.BaseRune + Key GoDocs May 17, 2024
Copy link
Member

@aymanbagabas aymanbagabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, some nitpicks

input/key.go Outdated Show resolved Hide resolved
input/key.go Outdated Show resolved Hide resolved
input/key.go Outdated Show resolved Hide resolved
@meowgorithm
Copy link
Member Author

Cool, going to accept these and then adjust a tiny bit more.

@meowgorithm
Copy link
Member Author

Okay cool, I think we're good here if you do, @aymanbagabas.

@aymanbagabas aymanbagabas merged commit 993171a into main May 17, 2024
10 checks passed
@aymanbagabas aymanbagabas deleted the input-edits branch May 17, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants