Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): Allow null value for base #37

Merged
merged 5 commits into from
Feb 13, 2025
Merged

Conversation

bschimke95
Copy link
Contributor

You explicitly need to set nullable=false, otherwise the validation will kick in and not set the default value.

Copy link
Member

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have you had success deploying the charm with this provider. I'm not sure all the terraform/versions.tf need to align or not. So far every other version we've used i 0.14.0

@bschimke95 bschimke95 force-pushed the KU-2592/terraform-ceph branch from de4cccb to fca908f Compare February 12, 2025 13:30
@bschimke95
Copy link
Contributor Author

This was just a test to check if the version bump fixes the juju provider issue. It didn't so I reverted it.

@bschimke95 bschimke95 merged commit 664d539 into main Feb 13, 2025
13 checks passed
@bschimke95 bschimke95 deleted the KU-2592/terraform-ceph branch February 13, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants