Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to sea-orm instead of Diesel #1852

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from
Draft

Conversation

auguwu
Copy link
Member

@auguwu auguwu commented Feb 2, 2025

yet another PR that Noel makes that refractors a whole lot but this is the last time I swear!

This gigantic PR migrates away from Diesel and experiments with sea-orm. There are numerous reasons why I decided to migrate to sea-orm:

While sea-orm does require some code to work for newtypes and other fun stuff, it isn't as from diesel and trying to juggle multiple databases is very easy and doesn't even require the hard work (like charted_database::connection! and such)

This PR also cleans up the crates/ library and prepares the charted-types and charted-core crates to be public to crates.io for the REST client (charted-client) to be readily available at launch.

@auguwu auguwu added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file rust Pull requests that update Rust code deps labels Feb 2, 2025
Copy link
Contributor

@spotlightishere spotlightishere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic - thank you so much for migrating everything over! I'm a little confused on why cargo deny is failing here, but I don't believe it's our fault.

I believe this should be set to merge; would it be possible to rebase everything on top of recent commits?

@auguwu auguwu marked this pull request as draft February 2, 2025 23:25
@auguwu
Copy link
Member Author

auguwu commented Feb 2, 2025

This is fantastic - thank you so much for migrating everything over! I'm a little confused on why cargo deny is failing here, but I don't believe it's our fault.

I believe this should be set to merge; would it be possible to rebase everything on top of recent commits?

I forgot to set the PR to a draft, everything is not 100% finished yet. But, it shouldn't hurt to rebase everything now.

CI will need a bit of updating (especially our release pipeline, which is going to be a lot more complex and require a lot of compute (I am tempted to get GitHub Teams for this organization so we can have the large runners as I do not have access to aarch64 Linux machines))

@auguwu auguwu removed the request for review from IceeMC February 2, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file deps documentation Improvements or additions to documentation rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants