Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hx-ws #108

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Add hx-ws #108

merged 1 commit into from
Feb 4, 2024

Conversation

chasefleming
Copy link
Owner

No description provided.

@chasefleming chasefleming merged commit 5f66c07 into main Feb 4, 2024
1 check passed
@chasefleming chasefleming deleted the chasefleming/hx-ws branch February 4, 2024 21:13
@dreth
Copy link
Contributor

dreth commented Feb 5, 2024

Hey Chase, I didn't add hx-ws in my PR because of this:

image

But since you already added it, maybe you can also include hx-sse too, which is in the same condition (moved to an extension)

@chasefleming
Copy link
Owner Author

@dreth can you link that? Can't find it. From another page, I see that it only moves to an extension in v2, correct? I don't see an issue with adding support for anything in v1 as well. Is there anything else you thing would be beneficial as well that is currently missing?

@chasefleming
Copy link
Owner Author

Thanks @gedw99 ! Do you all think we should add sse-connect, sse-swap, and ws-connect as well?

@dreth
Copy link
Contributor

dreth commented Feb 6, 2024

What @gedw99 linked is more complete, but the screenshot i attached is from the end of this table: https://htmx.org/reference/#attributes-additional

@chasefleming I don't see the harm! If you want I can do this in a separate branch

@chasefleming
Copy link
Owner Author

Sure, that would be awesome. Thanks @dreth !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants